vrozov commented on code in PR #49276:
URL: https://github.com/apache/spark/pull/49276#discussion_r1941801041
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala:
##########
@@ -126,7 +126,9 @@ class CacheManager extends Logging with
AdaptiveSparkPlanHelper {
if (storageLevel == StorageLevel.NONE) {
// Do nothing for StorageLevel.NONE since it will not actually cache any
data.
} else if (lookupCachedDataInternal(normalizedPlan).nonEmpty) {
- logWarning("Asked to cache already cached data.")
+ logWarning(log"An attempt was made to cache data even though the data
had already been " +
Review Comment:
@gengliangwang
- I disagree that it is super confusing and explained when call to
`unpersist()` may be necessary.
- To move this PR forward I updated warning message and removed reference to
un-cache data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
