miland-db commented on code in PR #49427:
URL: https://github.com/apache/spark/pull/49427#discussion_r1938489768
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -159,44 +159,173 @@ class AstBuilder extends DataTypeAstBuilder
script
}
+ private def assertSqlState(sqlState: String): Unit = {
+ val sqlStateRegex = "^[A-Za-z0-9]{5}$".r
+ if (sqlStateRegex.findFirstIn(sqlState).isEmpty
+ || sqlState.startsWith("00")
+ || sqlState.startsWith("01")
+ || sqlState.startsWith("XX")) {
+ throw SqlScriptingErrors.invalidSqlStateValue(CurrentOrigin.get,
sqlState)
+ }
+ }
+
+ private def visitConditionValueImpl(
+ ctx: ConditionValueContext,
+ handlerTriggers: ExceptionHandlerTriggers): Unit = {
+ // Current element is SQLSTATE.
+ Option(ctx.sqlStateValue())
+ .foreach { sqlStateValueContext =>
+ val sqlState = sqlStateValueContext.getText.replace("'", "")
+ assertSqlState(sqlState)
+ handlerTriggers.addUniqueSqlState(sqlState)
+ }
+
+ // Current element is condition.
+ Option(ctx.multipartIdentifier())
+ .foreach { conditionContext =>
+ val conditionNameParts = visitMultipartIdentifier(conditionContext)
+ val conditionNameString =
conditionNameParts.mkString(".").toUpperCase(Locale.ROOT)
+ if (conditionNameParts.size > 1) {
+ if (!SparkThrowableHelper.isValidErrorClass(conditionNameString)) {
+ throw SqlScriptingErrors
+ .conditionCannotBeQualified(CurrentOrigin.get,
conditionNameString)
+ }
+ }
+ handlerTriggers.addUniqueCondition(conditionNameString)
+ }
+
+ Option(ctx.SQLEXCEPTION())
+ .foreach { _ =>
+ handlerTriggers.addUniqueSqlException()
+ }
+
+ // It is sufficient to check only NOT for NOT FOUND handler.
+ Option(ctx.NOT()).foreach { _ =>
+ handlerTriggers.addUniqueNotFound()
+ }
+ }
+
+ /**
+ * Visit list of condition/sqlstate values in handler declaration.
+ */
+ private def visitConditionValuesImpl(
+ ctx: ConditionValuesContext): ExceptionHandlerTriggers = {
+
+ val handlerTriggers: ExceptionHandlerTriggers = new
ExceptionHandlerTriggers()
+
+ ctx.cvList.forEach { cvContext =>
+ visitConditionValueImpl(cvContext, handlerTriggers)
+ }
+
+ if (handlerTriggers.sqlException || handlerTriggers.notFound) {
+ if (handlerTriggers.conditions.nonEmpty ||
handlerTriggers.sqlStates.nonEmpty) {
+ throw SqlScriptingErrors
+
.sqlExceptionOrNotFoundCannotBeCombinedWithOtherConditions(CurrentOrigin.get)
+ }
+
+ }
+
+ handlerTriggers
+ }
+
+ private def visitDeclareConditionStatementImpl(
+ ctx: DeclareConditionStatementContext): ErrorCondition = {
+ val conditionName = ctx.multipartIdentifier().getText
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
