vladimirg-db commented on code in PR #49750:
URL: https://github.com/apache/spark/pull/49750#discussion_r1937610299
##########
sql/core/src/test/resources/sql-tests/inputs/group-by.sql:
##########
@@ -64,6 +78,10 @@ set spark.sql.groupByAliases=false;
-- Check analysis exceptions
SELECT a AS k, COUNT(b) FROM testData GROUP BY k;
+SELECT 1 GROUP BY `1`;
+
+-- GROUP BY column with name same as an alias used in the project list
+SELECT 1 AS a FROM testData GROUP BY `a`;
Review Comment:
This is a duplicate.
##########
sql/core/src/test/resources/sql-tests/inputs/group-by.sql:
##########
@@ -64,6 +78,10 @@ set spark.sql.groupByAliases=false;
-- Check analysis exceptions
SELECT a AS k, COUNT(b) FROM testData GROUP BY k;
+SELECT 1 GROUP BY `1`;
Review Comment:
This is a duplicate.
##########
sql/core/src/test/resources/sql-tests/inputs/group-by.sql:
##########
@@ -48,6 +48,20 @@ SELECT COUNT(DISTINCT b), COUNT(DISTINCT b, c) FROM (SELECT
1 AS a, 2 AS b, 3 AS
SELECT a AS k, COUNT(b) FROM testData GROUP BY k;
SELECT a AS k, COUNT(b) FROM testData GROUP BY k HAVING k > 1;
+-- GROUP BY literal
+SELECT a AS k FROM testData GROUP BY 'k';
+SELECT 1 AS k FROM testData GROUP BY 'k';
+
+-- GROUP BY alias with the function name
+SELECT concat_ws(' ', a, b) FROM testData GROUP BY `concat_ws( , a, b)`;
+
+-- GROUP BY column with name same as an alias used in the project list
+SELECT 1 AS a FROM testData GROUP BY a;
+SELECT 1 AS a FROM testData GROUP BY `a`;
+
+-- GROUP BY implicit alias
+SELECT 1 GROUP BY `1`;
Review Comment:
```suggestion
SELECT 1 GROUP BY `1`;
-- GROUP BY alias with the subquery name
SELECT (SELECT a FROM testData LIMIT 1) + (SELECT b FROM testData LIMIT 1)
FROM VALUES (1, 2) GROUP BY
`(SELECTaFROMtestDataLIMIT1)+(SELECTbFROMtestDataLIMIT1)`
-- GROUP BY with expression subqueries
SELECT a, count(*) FROM testData GROUP BY (SELECT b FROM testData)
SELECT a, count(*) FROM testData GROUP BY a, (SELECT b FROM testData)
SELECT a, count(*) FROM testData GROUP BY a, (SELECT b FROM testData LIMIT 1)
SELECT a, count(*) FROM testData GROUP BY a, b IN (SELECT a FROM testData)
SELECT a, count(*) FROM testData GROUP BY a, a IN (SELECT b FROM testData)
SELECT a, count(*) FROM testData GROUP BY a, EXISTS(SELECT b FROM testData)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
