HeartSaVioR commented on code in PR #49742:
URL: https://github.com/apache/spark/pull/49742#discussion_r1936705916


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/ListStateSuite.scala:
##########
@@ -99,6 +99,153 @@ class ListStateSuite extends StateVariableSuiteBase {
     }
   }
 
+  // verify that relative ordering of inserted elements is maintained on 
retrieval - long type

Review Comment:
   The expected behavior is the same with Array/List in Scala, right? Let's 
retain the expectation and apply the same operation, and compare. It'd be lot 
easier than enumerating all constants across multiple lines.
   
   I think this would help simplifying the test code a lot, especially for case 
class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to