cloud-fan commented on code in PR #49445:
URL: https://github.com/apache/spark/pull/49445#discussion_r1929954700
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala:
##########
@@ -1591,7 +1591,10 @@ case class TableSpec(
case class CreateVariable(
name: LogicalPlan,
defaultExpr: DefaultValueExpression,
- replace: Boolean) extends UnaryCommand with SupportsSubquery {
+ replace: Boolean,
+ // When false, this node can create local variables from SQL scripting.
Review Comment:
BTW do we really need this parameter? If the local variable manager is
present in the ThreadLocal, it means we are in scripting and we should create
local variables.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala:
##########
@@ -1591,7 +1591,10 @@ case class TableSpec(
case class CreateVariable(
name: LogicalPlan,
defaultExpr: DefaultValueExpression,
- replace: Boolean) extends UnaryCommand with SupportsSubquery {
+ replace: Boolean,
+ // When false, this node can create local variables from SQL scripting.
Review Comment:
The same to `SetVariable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
