milanisvet commented on code in PR #49571:
URL: https://github.com/apache/spark/pull/49571#discussion_r1926876850
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -1031,6 +1038,9 @@ object ColumnPruning extends Rule[LogicalPlan] {
} else {
p
}
+ // TODO: Pruning `UnionLoop`s needs to take into account both the outer
`Project` and the inner
+ // `UnionLoopRef` nodes.
Review Comment:
I tried to run the code without this line, but it does not work,
`mergeChildOutputs` throws an error that not all child outputs are of the same
size, so we probably keep it then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
