LuciferYang commented on code in PR #49602: URL: https://github.com/apache/spark/pull/49602#discussion_r1925193660
########## sql/api/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala: ########## @@ -139,7 +139,7 @@ abstract class DataFrameWriter[T] { * * @since 1.4.0 */ - def options(options: util.Map[String, String]): this.type = { + def options(options: Map[String, String]): this.type = { Review Comment: Since `Map` by default represents `scala.collection.immutable.Map` in Scala 2.13, I prefer the fix approach suggested by @yaooqinn here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org