wengh commented on code in PR #49535: URL: https://github.com/apache/spark/pull/49535#discussion_r1924462859
########## core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala: ########## @@ -122,6 +122,7 @@ private[spark] abstract class BasePythonRunner[IN, OUT]( protected val authSocketTimeout = conf.get(PYTHON_AUTH_SOCKET_TIMEOUT) private val reuseWorker = conf.get(PYTHON_WORKER_REUSE) protected val faultHandlerEnabled: Boolean = conf.get(PYTHON_WORKER_FAULTHANLDER_ENABLED) + protected val hideTraceback: Boolean = false Review Comment: The config is defined in `org.apache.spark.sql.internal.SQLConf` which seems to be inaccessible from here. `PYSPARK_SIMPLIFIED_TRACEBACK` is also defined in `SQLConf` so `BasePythonRunner` subclasses have to override it. Is there an advantage for putting it in `SQLConf` rather than e.g. `org.apache.spark.internal.config.Python`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
