changgyoopark-db commented on code in PR #49549:
URL: https://github.com/apache/spark/pull/49549#discussion_r1922049578
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala:
##########
@@ -324,12 +324,14 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan]
with PredicateHelper {
}
}
- private def addCastIfNeeded(expression: Expression, expectedDataType:
DataType) =
- if (expression.dataType == expectedDataType) {
- expression
+ private def addCastIfNeeded(expression: Expression, expectedDataType:
DataType) = {
+ val cast = Cast(expression, expectedDataType)
+ if (cast.needsTimeZone) {
+ cast.withTimeZone(conf.sessionLocalTimeZone)
Review Comment:
Cast(x, y) always leaves the timezone field None, but who knows, that might
change. I'll add a new change anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
