HyukjinKwon commented on code in PR #49550: URL: https://github.com/apache/spark/pull/49550#discussion_r1921670214
########## project/plugins.sbt: ########## @@ -21,9 +21,6 @@ addSbtPlugin("software.purpledragon" % "sbt-checkstyle-plugin" % "4.0.1") // please check pom.xml in the root of the source tree too. libraryDependencies += "com.puppycrawl.tools" % "checkstyle" % "10.20.2" -// checkstyle uses guava 33.3.1-jre. -libraryDependencies += "com.google.guava" % "guava" % "33.3.1-jre" Review Comment: I do remember. It was done at https://github.com/apache/spark/commit/4a14dc0aff9cac85390cab94bc183271fa95beef, and scalas scheck style failed because of Guava version mismatch (SBT specifically). Since the Guava version in `plugins.sbt` here doesn't affect the main code, we can just set whatever version we want. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org