LuciferYang commented on code in PR #49562:
URL: https://github.com/apache/spark/pull/49562#discussion_r1921047077
##########
project/SparkBuild.scala:
##########
@@ -90,8 +90,6 @@ object BuildCommons {
// Google Protobuf version used for generating the protobuf.
// SPARK-41247: needs to be consistent with `protobuf.version` in `pom.xml`.
val protoVersion = "4.29.3"
Review Comment:
https://github.com/apache/spark/blob/93e56c26acec8455ec532fcedea9e22fd05a288a/project/SparkBuild.scala#L1113-L1135
Due to the `sbtpomreader.PomReaderPlugin` being disabled in `OldDeps`, if a
similar approach is used to obtain `protoVersion`, it will fail to retrieve it
at line 1132. Therefore, in the current PR, only the retrieval of `grpcVersion`
has been fixed. I will address the retrieval method for `protoVersion` once I
find a suitable approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
