zhengruifeng commented on code in PR #49553:
URL: https://github.com/apache/spark/pull/49553#discussion_r1920894533
##########
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala:
##########
@@ -903,7 +903,7 @@ class LinearRegressionSummary private[regression] (
val labelCol: String,
val featuresCol: String,
private val privateModel: LinearRegressionModel,
- private val diagInvAtWA: Array[Double]) extends Serializable {
+ private val diagInvAtWA: Array[Double]) extends Summary with Serializable {
Review Comment:
https://github.com/apache/spark/blob/2721a50234b05db3e59b5a37225f9358978a4590/sql/connect/server/src/main/scala/org/apache/spark/sql/connect/ml/MLHandler.scala#L132-L145
The `FETCH` command handle `Summary` separately, we don't have a trait
`RegressionSummary` (like `ClassificationSummary`), if we don't make
`LinearRegressionSummary` extends `Summary` than the `FETCH` command will try
to serialize the `LinearRegressionSummary` and cause failure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
