stevomitric commented on code in PR #49554:
URL: https://github.com/apache/spark/pull/49554#discussion_r1920344710
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -460,6 +469,8 @@ static CollationMeta loadCollationMeta(CollationIdentifier
collationIdentifier)
}
return collationSpecUTF8;
}
+
+ protected SpaceTrimming spaceTrimming;
Review Comment:
It is used in other instances to determine trimming. We can followup with a
rename of TRIM collation to PAD (?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
