LuciferYang commented on code in PR #49546:
URL: https://github.com/apache/spark/pull/49546#discussion_r1919690611
##########
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java:
##########
@@ -216,7 +216,7 @@ public void expandPointerArray(LongArray newArray) {
if (array != null) {
if (newArray.size() < array.size()) {
// checkstyle.off: RegexpSinglelineJava
Review Comment:
it Is needed because of the following inspection rule:
https://github.com/apache/spark/blob/3b0ac45391708642ce6a1779e3c234bab0e40b66/dev/checkstyle.xml#L171-L174
If removed, running `dev/lint-java` will result in the following error:
```
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java:[218]
(regexp) RegexpSinglelineJava: Avoid throwing error in application code.
```
##########
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java:
##########
@@ -216,7 +216,7 @@ public void expandPointerArray(LongArray newArray) {
if (array != null) {
if (newArray.size() < array.size()) {
// checkstyle.off: RegexpSinglelineJava
Review Comment:
it Is needed because of the following checkstyle rule:
https://github.com/apache/spark/blob/3b0ac45391708642ce6a1779e3c234bab0e40b66/dev/checkstyle.xml#L171-L174
If removed, running `dev/lint-java` will result in the following error:
```
[ERROR]
src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java:[218]
(regexp) RegexpSinglelineJava: Avoid throwing error in application code.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
