HyukjinKwon commented on code in PR #49473:
URL: https://github.com/apache/spark/pull/49473#discussion_r1914176714
##########
connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/ProtobufSerializer.scala:
##########
@@ -52,6 +52,10 @@ private[sql] class ProtobufSerializer(
rootCatalystType match {
case st: StructType =>
newStructConverter(st, rootDescriptor, Nil, Nil).asInstanceOf[Any
=> Any]
+ case _ =>
+ throw QueryCompilationErrors.cannotConvertSqlTypeToProtobufError(
+ rootDescriptor.getName,
+ rootCatalystType)
Review Comment:
We're already catching this below. Can we update that instead, and describe
when this can happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
