zhengruifeng commented on PR #48791: URL: https://github.com/apache/spark/pull/48791#issuecomment-2586104252
> Hi @zhengruifeng, > > > I also think we can optimize out the message Param: > > option 1: support Vector and Matrix in message Literal; > > option 2 (Preferred): Using message Expression or Expression.Literal.Struct to express the parameters; > > If you insist on optimizing it, I would like to add vector/matrix in the Literal. What's your opinion? Actually, I personally prefer option 2 (Using `Expression.Literal.Struct`) to minimize the protobuf changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
