cloud-fan commented on code in PR #49455:
URL: https://github.com/apache/spark/pull/49455#discussion_r1912610718
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala:
##########
@@ -188,10 +187,12 @@ case class CatalogTablePartition(
map += ("Partition Parameters" -> paramsJson)
}
- map += ("Created Time" -> JString(new Date(createTime).toString))
+ map += ("Created Time" -> JString(
+
DateTimeUtils.microsToInstant(DateTimeUtils.millisToMicros(createTime)).toString))
Review Comment:
do we need to pass the session timezone?
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala:
##########
@@ -188,10 +187,12 @@ case class CatalogTablePartition(
map += ("Partition Parameters" -> paramsJson)
}
- map += ("Created Time" -> JString(new Date(createTime).toString))
+ map += ("Created Time" -> JString(
+
DateTimeUtils.microsToInstant(DateTimeUtils.millisToMicros(createTime)).toString))
val lastAccess = if (lastAccessTime <= 0) JString("UNKNOWN")
- else JString(new Date(lastAccessTime).toString)
+ else JString(
+
DateTimeUtils.microsToInstant(DateTimeUtils.millisToMicros(createTime)).toString)
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
