sunxiaoguang commented on code in PR #49452:
URL: https://github.com/apache/spark/pull/49452#discussion_r1912448035
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala:
##########
@@ -986,4 +986,18 @@ private[v2] trait V2JDBCTest extends SharedSparkSession
with DockerIntegrationFu
test("scan with filter push-down with date time functions") {
testDatetime(s"$catalogAndNamespace.${caseConvert("datetime")}")
}
+
+ test("SPARK-50792 Format binary data as a binary literal in JDBC.") {
+ withTable(s"$catalogName.test_binary_literal") {
+ // Create a table with binary column
+ val binary = "X'123456'"
+ val tableName = "test_binary_literal"
+
+ sql(s"CREATE TABLE $catalogName.$tableName (binary_col BINARY)")
+ sql(s"INSERT INTO $catalogName.$tableName VALUES ($binary)")
+
+ val select = s"SELECT * FROM $catalogName.$tableName WHERE binary_col =
$binary"
+ assert(spark.sql(select).collect().length === 1, s"Binary literal test
failed: $select")
+ }
+ }
Review Comment:
I suggest leave rearchitect another separate piece of work.
Since binary literal was not working for any of connectors before this PR.
We can get them fixed for now, and work on V2ExpressionSQLBuilder refactoring
to make it flexible enough to generate connector specific code like it is in
this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
