srielau commented on code in PR #49275:
URL: https://github.com/apache/spark/pull/49275#discussion_r1911592696
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -2800,6 +2800,30 @@
},
"sqlState" : "42K0E"
},
+ "INVALID_LOG_VERSION" : {
+ "message" : [
+ "UnsupportedLogVersion."
+ ],
+ "subClass" : {
+ "EXACT_MATCH_VERSION" : {
+ "message" : [
+ "the only supported log version is v<matchVersion>, but encountered
v<version>."
+ ]
+ },
+ "MAX_SUPPORTED_VERSION" : {
+ "message" : [
+ "maximum supported log version is v<maxSupportedVersion>, but
encountered v<version>. The log file was produced by a newer version of Spark
and cannot be read by this version. Please upgrade."
+ ]
+ }
+ },
+ "sqlState" : "22023"
Review Comment:
```suggestion
"sqlState" : "KD002"
```
Unexpected Version
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -2800,6 +2800,30 @@
},
"sqlState" : "42K0E"
},
+ "INVALID_LOG_VERSION" : {
+ "message" : [
+ "UnsupportedLogVersion."
+ ],
+ "subClass" : {
+ "EXACT_MATCH_VERSION" : {
+ "message" : [
+ "the only supported log version is v<matchVersion>, but encountered
v<version>."
Review Comment:
```suggestion
"The only supported log version is v<matchVersion>, but
encountered v<version>."
```
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -2800,6 +2800,30 @@
},
"sqlState" : "42K0E"
},
+ "INVALID_LOG_VERSION" : {
+ "message" : [
+ "UnsupportedLogVersion."
+ ],
+ "subClass" : {
+ "EXACT_MATCH_VERSION" : {
+ "message" : [
+ "the only supported log version is v<matchVersion>, but encountered
v<version>."
+ ]
+ },
+ "MAX_SUPPORTED_VERSION" : {
+ "message" : [
+ "maximum supported log version is v<maxSupportedVersion>, but
encountered v<version>. The log file was produced by a newer version of Spark
and cannot be read by this version. Please upgrade."
+ ]
+ }
+ },
+ "sqlState" : "22023"
+ },
+ "INVALID_METADATA_VERSION" : {
+ "message" : [
+ "Log file was malformed: failed to read correct log version from <text>."
+ ],
+ "sqlState" : "22023"
Review Comment:
```suggestion
"sqlState" : "KD002"
```
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -2800,6 +2800,30 @@
},
"sqlState" : "42K0E"
},
+ "INVALID_LOG_VERSION" : {
+ "message" : [
+ "UnsupportedLogVersion."
+ ],
+ "subClass" : {
+ "EXACT_MATCH_VERSION" : {
+ "message" : [
+ "the only supported log version is v<matchVersion>, but encountered
v<version>."
+ ]
+ },
+ "MAX_SUPPORTED_VERSION" : {
+ "message" : [
+ "maximum supported log version is v<maxSupportedVersion>, but
encountered v<version>. The log file was produced by a newer version of Spark
and cannot be read by this version. Please upgrade."
Review Comment:
```suggestion
"The maximum supported log version is v<maxSupportedVersion>, but
encountered v<version>. The log file was produced by a newer version of Spark
and cannot be read by this version. You need to upgrade."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
