dongjoon-hyun commented on PR #49443:
URL: https://github.com/apache/spark/pull/49443#issuecomment-2583025520
I'm not sure why you say like that with `-e`.
> This is a bit of a weird patch. The mvn command should actually continue
checking for `$?` and not for the error output being empty. In particular
because it parses for "Unformatted files"
>
> Not the second issue is that the lint-scala should not care about the code
in
>
> ```
>
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/ExecutorKubernetesCredentialsFeatureStepSuite.scala
> ```
>
> The mvn command explicitly just checks for
>
> ```
> -pl sql/api \
> -pl sql/connect/common \
> -pl sql/connect/server \
> -pl connector/connect/client/jvm \
> ```
It's a standard way to stop script if some command exist abnormally during
the script. Apache Spark utilizes it in many script. Are you aware of it,
@grundprinzip ?
```
$ git grep 'set -e' | wc -l
33
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
