pan3793 commented on code in PR #49440:
URL: https://github.com/apache/spark/pull/49440#discussion_r1910127015
##########
connector/profiler/README.md:
##########
@@ -54,7 +54,7 @@ Then enable the profiling in the configuration.
<td><code>spark.executor.profiling.dfsDir</code></td>
<td>(none)</td>
<td>
- An HDFS compatible path to which the profiler's output files are copied.
The output files will be written as
<i>dfsDir/application_id/profile-appname-exec-executor_id.jfr</i> <br/>
+ An HDFS compatible path to which the profiler's output files are copied.
The output files will be written as
<i>dfsDir/{{APP_ID}}/profile-{{APP_ID}}-exec-{{EXECUTOR_ID}}.jfr</i> <br/>
Review Comment:
actually, `{{APP_ID}}` is `nameForAppAndAttempt`(see code) for YARN cluster
mode, but writing behavior details in the configuration description is a little
bit verbose ...
please let me know if you have better suggestion to polish this sentence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
