cloud-fan commented on code in PR #49103: URL: https://github.com/apache/spark/pull/49103#discussion_r1910006967
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala: ########## @@ -323,6 +326,9 @@ case class PreprocessTableCreation(catalog: SessionCatalog) extends Rule[Logical SchemaUtils.checkTransformDuplication( partitioning, "in the partitioning", isCaseSensitive) + // Check that columns do not have indeterminate collation + SchemaUtils.checkIndeterminateCollationInSchema(schema) Review Comment: no need to check it here as `CheckAnalysis` will do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org