dongjoon-hyun commented on code in PR #49425:
URL: https://github.com/apache/spark/pull/49425#discussion_r1909116747
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -5773,7 +5773,8 @@ class SQLConf extends Serializable with Logging with
SqlApiConf {
def trimCollationEnabled: Boolean = getConf(TRIM_COLLATION_ENABLED)
override def defaultStringType: StringType = {
- if (getConf(DEFAULT_COLLATION).toUpperCase(Locale.ROOT) == "UTF8_BINARY") {
+ if (getConf(DEFAULT_COLLATION).toUpperCase(Locale.ROOT) ==
+ CollationFactory.UTF8_BINARY_COLLATION_NAME) {
Review Comment:
nit, maybe, two more spaces for indentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
