cloud-fan commented on code in PR #49383:
URL: https://github.com/apache/spark/pull/49383#discussion_r1908125503
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala:
##########
@@ -92,12 +93,19 @@ class QueryExecution(
}
private val lazyAnalyzed = LazyTry {
- val plan = executePhase(QueryPlanningTracker.ANALYSIS) {
- // We can't clone `logical` here, which will reset the `_analyzed` flag.
- sparkSession.sessionState.analyzer.executeAndCheck(logical, tracker)
+ val plan = Try {
Review Comment:
can we use the primitive try?
```
try {
val plan = ...
...
} catch {
case NonFatal(_) => tracker. setAnalysisFailed...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]