davidm-db commented on code in PR #49372:
URL: https://github.com/apache/spark/pull/49372#discussion_r1907042427
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionContext.scala:
##########
@@ -63,7 +63,7 @@ class SqlScriptingExecutionFrame(
}
def enterScope(label: String): Unit = {
- scopes.addOne(new SqlScriptingExecutionScope(label))
+ scopes.append(new SqlScriptingExecutionScope(label))
Review Comment:
nit: you have `addOne` in few other places:
- `private val context` in `SqlScriptingExecutionContext.scala`
- `context.frames.addOne` in `SqlScriptingInterpreterSuite.scala`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
