eejbyfeldt commented on PR #48477: URL: https://github.com/apache/spark/pull/48477#issuecomment-2576959957
Would not the `TransformingEncoder` be enough of a customization point to implement the custom encoders provided by at least `frameless` (I am not familiar enough with the others)? I guess it not ideal as it would require a rewrite of that part of the library. But at least from my experiments creating custom encoders by first creating `AgnosticEncoders` is much easier than creating the `ExpressionEncoders` directly. And based on the comments by @hvanhovell it seems that is a better approach for downstream libraries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
