panbingkun commented on PR #49411: URL: https://github.com/apache/spark/pull/49411#issuecomment-2576895943
> Does it mean any time we add codegen support for some functions, there is a risk of perf regression? Are we sure `from_json` is the only one or it's simply because `SubExprEliminationBenchmark` tests `from_json`? - In the two scenarios tested in `SubExprEliminationBenchmark `, it has been found that the filter scenario has perf regression. - I can test other functions, such as those that have existed for a long time in history. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
