cloud-fan commented on code in PR #49386:
URL: https://github.com/apache/spark/pull/49386#discussion_r1906451581
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala:
##########
@@ -1071,3 +1072,29 @@ trait UnresolvedPlanId extends LeafExpression with
Unevaluable {
// Subclasses can override this function to provide more TreePatterns.
def nodePatternsInternal(): Seq[TreePattern] = Seq()
}
+
+case class UnresolvedWithColumns(
+ colNames: Seq[String],
+ exprs: Seq[Expression],
+ metadata: Option[Seq[Metadata]],
+ child: LogicalPlan)
+ extends UnresolvedUnaryNode {
+
+ final override val nodePatterns: Seq[TreePattern] =
Seq(UNRESOLVED_WITH_COLUMNS)
+
+ override protected def withNewChildInternal(
+ newChild: LogicalPlan): UnresolvedWithColumns = copy(child = newChild)
+}
+
+case class UnresolvedWithColumnsRenamed(
Review Comment:
I see. One question is shall we add new logical plans or new star-like
expressions? star-like expressions are more flexible as they work for function
input as well (e.g. `struct(*)`). And we might be able to unify them with the
SQL pipe one with extra flags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
