anishshri-db commented on code in PR #49277:
URL: https://github.com/apache/spark/pull/49277#discussion_r1906238403
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala:
##########
@@ -402,15 +419,27 @@ private[sql] class RocksDBStateStoreProvider
stateStoreName = stateStoreId.storeName,
colFamilyName = StateStore.DEFAULT_COL_FAMILY_NAME)
- val dataEncoder = getDataEncoder(
- stateStoreEncoding, dataEncoderCacheKey, keyStateEncoderSpec,
valueSchema)
+ // For test cases only: TestStateSchemaProvider allows dynamically adding
schemas
+ // during test execution to verify schema evolution behavior. In
production,
+ // schemas are loaded from checkpoint data
+ stateSchemaProvider match {
+ case Some(t: TestStateSchemaProvider) =>
Review Comment:
cc - @HeartSaVioR - in case he can think of a way of moving this to the test
dirs. can also do this in a follow up PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
