allisonwang-db commented on code in PR #49389:
URL: https://github.com/apache/spark/pull/49389#discussion_r1904945707
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala:
##########
@@ -1532,10 +1535,49 @@ class SessionCatalog(
}
}
+ /**
+ * Create a user defined function.
+ */
+ def createUserDefinedFunction(function: UserDefinedFunction, ignoreIfExists:
Boolean): Unit = {
+ createFunction(function.toCatalogFunction, ignoreIfExists)
+ }
+
// ----------------------------------------------------------------
// | Methods that interact with temporary and metastore functions |
// ----------------------------------------------------------------
+ /**
+ * Constructs a [[FunctionBuilder]] based on the provided class that
represents a function.
+ */
+ private def makeSQLFunctionBuilder(function: SQLFunction): FunctionBuilder =
{
Review Comment:
I think it's fine to use `makeSQLFunctionBuilder` since we use
`FunctionBuilder` to reference all scalar functions :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
