cloud-fan commented on code in PR #49237:
URL: https://github.com/apache/spark/pull/49237#discussion_r1904902717
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala:
##########
@@ -298,8 +281,8 @@ case class Uniform(min: Expression, max: Expression,
seedExpression: Expression,
cast(min, DoubleType),
Multiply(
Subtract(
- cast(max, DoubleType),
- cast(min, DoubleType)),
+ cast(If(IsNull(max), Literal(null, max.dataType), max),
DoubleType),
Review Comment:
hmm is this necessary? Cast is null-propagating, so null input results to
null output already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
