hvanhovell commented on code in PR #49339:
URL: https://github.com/apache/spark/pull/49339#discussion_r1904354079
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -956,7 +956,7 @@ class Dataset[T] private[sql] (
val generator = SparkUserDefinedFunction(
UDFAdaptors.iterableOnceToSeq(f),
UnboundRowEncoder :: Nil,
- ScalaReflection.encoderFor[Seq[A]])
+ ScalaReflection.encoderForWithRowEncoderSupport[Seq[A]])
Review Comment:
Please keep in mind that for encoders that are used to convert data from the
external representation to the internal representation we need an encoder with
a valid schema. An UnboundRowEncoder does not have a valid/meaningful schema.
It should not be used in these cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
