cloud-fan commented on code in PR #49237:
URL: https://github.com/apache/spark/pull/49237#discussion_r1893568612
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala:
##########
@@ -49,6 +49,9 @@ trait RDG extends Expression with ExpressionWithRandomSeed {
@transient protected lazy val seed: Long = seedExpression match {
case e if e.dataType == IntegerType => e.eval().asInstanceOf[Int]
case e if e.dataType == LongType => e.eval().asInstanceOf[Long]
+ case e if e.dataType == FloatType => e.eval().asInstanceOf[Float].toLong
+ case e if e.dataType == DoubleType => e.eval().asInstanceOf[Double].toLong
+ case e if e.dataType.isInstanceOf[DecimalType] =>
e.eval().asInstanceOf[Decimal].toLong
Review Comment:
BTW do we really expect users to use float/double/decimal as the random seed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
