xupefei commented on code in PR #49111:
URL: https://github.com/apache/spark/pull/49111#discussion_r1891676841
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala:
##########
@@ -460,14 +460,20 @@ private class KeyValueGroupedDatasetImpl[K, V, IK, IV](
}
override protected def aggUntyped(columns: TypedColumn[_, _]*): Dataset[_] =
{
- // TODO(SPARK-43415): For each column, apply the valueMap func first...
+ val aggCols: Seq[Column] = valueMapFunc match {
Review Comment:
I tried the projection idea solely on the client side, and it seems non
trivial: `fn(col(*)).as("value)")` is expecting `*` to be columns after
applying the key mapping function.
I'll see if bringing `AppendColumns` to protobuf can help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
