cloud-fan commented on code in PR #48621:
URL: https://github.com/apache/spark/pull/48621#discussion_r1847536726
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -377,6 +378,17 @@ abstract class JdbcDialect extends Serializable with
Logging {
}
private[jdbc] class JDBCSQLBuilder extends V2ExpressionSQLBuilder {
+ def inputToCaseWhenSQL(input: Expression): String =
+ "CASE WHEN " + inputToSQL(input) + " THEN 1 ELSE 0 END"
+
+ def inputToIntSQL(expr: Expression): String = {
+ expr match {
+ case p: Predicate if p.name() != "ALWAYS_TRUE" && p.name() !=
"ALWAYS_FALSE" =>
Review Comment:
so back to my first question: is this specific to sqlserver? If yes, shall
we document it so that the callers of this method should do the same thing as
`MsSqlServerDialect`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
