gatorsmile commented on code in PR #47606: URL: https://github.com/apache/spark/pull/47606#discussion_r1705971783
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala: ########## @@ -645,6 +633,21 @@ private[sql] object DataSourceV2Strategy extends Logging { logWarning(log"Can't translate ${MDC(EXPR, other)} to source filter, unsupported expression") None } + + private def withProjectAndFilter( Review Comment: Should we change it to `protected[sql]` like the other utility function in DataSourceV2Strategy? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org