cloud-fan commented on code in PR #47628:
URL: https://github.com/apache/spark/pull/47628#discussion_r1705588735


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala:
##########
@@ -1385,8 +1385,10 @@ abstract class DDLSuite extends QueryTest with 
DDLSuiteBase {
             exception = intercept[AnalysisException] {
               sql(s"SHOW COLUMNS IN $db.showcolumn FROM 
${db.toUpperCase(Locale.ROOT)}")
             },
-            errorClass = "_LEGACY_ERROR_TEMP_1057",
-            parameters = Map("dbA" -> db.toUpperCase(Locale.ROOT), "dbB" -> db)
+            errorClass = "SHOW_COLUMNS_WITH_CONFLICT_NAMESPACE",

Review Comment:
   shall we move all the related test cases to the new `ShowColumnsSuiteBase`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to