hvanhovell commented on code in PR #47572:
URL: https://github.com/apache/spark/pull/47572#discussion_r1705482291
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala:
##########
@@ -342,7 +342,8 @@ case class UnresolvedFunction(
isDistinct: Boolean,
filter: Option[Expression] = None,
ignoreNulls: Boolean = false,
- orderingWithinGroup: Seq[SortOrder] = Seq.empty)
+ orderingWithinGroup: Seq[SortOrder] = Seq.empty,
+ isInternal: Boolean = false)
Review Comment:
I think it is fine for two reasons:
1. It should be very rare to add an internal function. As a 3p extension
developer you generally want the SQL Dataframe surface to match.
2. A 3p developer should not really be creating these UnresolvedFunctions.
This should be done using the Column API, and indirectly through the Spark API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
