pan3793 commented on code in PR #47627: URL: https://github.com/apache/spark/pull/47627#discussion_r1705264618
########## dev/deps/spark-deps-hadoop-3-hive-2.3: ########## @@ -62,11 +62,12 @@ derby/10.16.1.1//derby-10.16.1.1.jar derbyshared/10.16.1.1//derbyshared-10.16.1.1.jar derbytools/10.16.1.1//derbytools-10.16.1.1.jar dropwizard-metrics-hadoop-metrics2-reporter/0.1.2//dropwizard-metrics-hadoop-metrics2-reporter-0.1.2.jar +error_prone_annotations/2.18.0//error_prone_annotations-2.18.0.jar Review Comment: short answer, no, but Guava changed it to compile scope in https://github.com/google/gson/pull/2346 I'm okay with either include or exclude it from Spark classpath ########## dev/deps/spark-deps-hadoop-3-hive-2.3: ########## @@ -62,11 +62,12 @@ derby/10.16.1.1//derby-10.16.1.1.jar derbyshared/10.16.1.1//derbyshared-10.16.1.1.jar derbytools/10.16.1.1//derbytools-10.16.1.1.jar dropwizard-metrics-hadoop-metrics2-reporter/0.1.2//dropwizard-metrics-hadoop-metrics2-reporter-0.1.2.jar +error_prone_annotations/2.18.0//error_prone_annotations-2.18.0.jar Review Comment: short answer, no, but Gson changed it to compile scope in https://github.com/google/gson/pull/2346 I'm okay with either include or exclude it from Spark classpath -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
