hvanhovell commented on code in PR #47573: URL: https://github.com/apache/spark/pull/47573#discussion_r1704565599
########## sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala: ########## @@ -1204,42 +1204,32 @@ class JsonFunctionsSuite extends QueryTest with SharedSparkSession { val df = Seq("""{"a":1}""").toDF("json") val invalidJsonSchema = """{"fields": [{"a":123}], "type": "struct"}""" checkError( - exception = intercept[SparkIllegalArgumentException] { + exception = intercept[AnalysisException] { Review Comment: These changes are a result of the parsing order. The only thing we can do to make this better is to homogenise schema parsing errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org