cloud-fan commented on code in PR #47545: URL: https://github.com/apache/spark/pull/47545#discussion_r1704078860
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/AddMapSortInAggregate.scala: ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.optimizer + +import scala.collection.mutable + +import org.apache.spark.sql.catalyst.expressions.{Alias, ArrayTransform, CreateNamedStruct, Expression, GetStructField, If, IsNull, LambdaFunction, Literal, MapFromArrays, MapKeys, MapSort, MapValues, NamedExpression, NamedLambdaVariable} +import org.apache.spark.sql.catalyst.plans.logical.{Aggregate, LogicalPlan} +import org.apache.spark.sql.catalyst.rules.Rule +import org.apache.spark.sql.types.{ArrayType, MapType, StructType} +import org.apache.spark.util.ArrayImplicits.SparkArrayOps + +/** + * Adds [[MapSort]] to group expressions containing map columns, as the key/value paris need to be + * in the correct order before grouping: + * + * SELECT COUNT(*) FROM TABLE GROUP BY map_column => + * SELECT COUNT(*) FROM TABLE GROUP BY map_sort(map_column) + * + * SELECT map_column, COUNT(*) FROM TABLE GROUP BY map_column => + * SELECT map_sort(map_column) as map_column, COUNT(*) FROM TABLE GROUP BY map_sort(map_column) + * + * SELECT map_expr as c, COUNT(*) FROM TABLE GROUP BY map_expr => + * SELECT map_sort(map_expr) as c, COUNT(*) FROM TABLE GROUP BY map_sort(map_expr) + */ +object AddMapSortInAggregate extends Rule[LogicalPlan] { Review Comment: is it a simple rename? not sure why git diff doesn't detect it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
