cloud-fan commented on code in PR #47582:
URL: https://github.com/apache/spark/pull/47582#discussion_r1703675320
##########
connector/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala:
##########
@@ -921,6 +921,34 @@ abstract class AvroSuite
}
}
+ test("SPARK-49082: Widening type promotions in AvroDeserializer") {
+ withTempPath { tempPath =>
+ // Int -> Long
+ val intPath = s"$tempPath/int_data"
+ val intDf = Seq(1, Int.MinValue, Int.MaxValue).toDF("col")
+ intDf.write.format("avro").save(intPath)
+ checkAnswer(
+ spark.read.schema("col Long").format("avro").load(intPath),
+ Seq(Row(1L), Row(-2147483648L), Row(2147483647L))
+ )
+
+ // Int -> Double
+ checkAnswer(
+ spark.read.schema("col Double").format("avro").load(intPath),
+ Seq(Row(1D), Row(-2147483648D), Row(2147483647D))
+ )
+
+ // Float -> Double
+ val floatPath = s"$tempPath/float_data1"
+ val floatDf = Seq(1, -1f, 2f).toDF("col")
Review Comment:
can we also test +/- infinity and nan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
