cloud-fan commented on code in PR #47374:
URL: https://github.com/apache/spark/pull/47374#discussion_r1694383494
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/QueryStageExec.scala:
##########
@@ -154,14 +154,14 @@ abstract class QueryStageExec extends LeafExecNode {
abstract class ExchangeQueryStageExec extends QueryStageExec {
/**
- * Cancel the stage materialization if in progress; otherwise do nothing.
+ * Cancel the stage materialization if in progress with a reason; otherwise
do nothing.
*/
- final def cancel(): Unit = {
+ final def cancel(reason: String): Unit = {
logDebug(s"Cancel query stage: $name")
- doCancel()
+ doCancel(Option(reason))
}
- protected def doCancel(): Unit
+ protected def doCancel(reason: Option[String]): Unit
Review Comment:
where do we call `doCancel` without a reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
