vladimirg-db commented on code in PR #47484: URL: https://github.com/apache/spark/pull/47484#discussion_r1691116665
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala: ########## @@ -248,10 +249,15 @@ case class PreprocessTableCreation(catalog: SessionCatalog) extends Rule[Logical DDLUtils.checkTableColumns(tableDesc.copy(schema = analyzedQuery.schema)) val output = analyzedQuery.output - val partitionAttrs = normalizedTable.partitionColumnNames.map { partCol => - output.find(_.name == partCol).get Review Comment: @HyukjinKwon do you know if the original code is correct? The attribute references here are compared by their names and not ids -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org