panbingkun commented on code in PR #47382:
URL: https://github.com/apache/spark/pull/47382#discussion_r1680361637
##########
common/unsafe/src/test/scala/org/apache/spark/unsafe/types/CollationFactorySuite.scala:
##########
@@ -154,8 +151,8 @@ class CollationFactorySuite extends AnyFunSuite with
Matchers { // scalastyle:ig
testCase.expectedResult)
val hash1 = collation.hashFunction.applyAsLong(toUTF8(testCase.s1))
- val hash2 = collation.hashFunction.applyAsLong(toUTF8(testCase.s1))
- assert(hash1 == hash2)
Review Comment:
Obviously, comparing `testCase.s1` and `testCase.s1` is meaningless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
