huaxingao commented on PR #47233: URL: https://github.com/apache/spark/pull/47233#issuecomment-2232086743
I took a look at Delta Lake's implementation for [update](https://github.com/delta-io/delta/blob/master/spark/src/main/scala/io/delta/tables/DeltaTable.scala#L234), which uses executeUpdate. To be consistent with Delta Lake's implementation, I think we probably want to have ``` spark.table("source") .update(Map("salary" -> lit(-1)), $"pk" >= 2) ``` instead of ``` spark.table("source") .update(Map("salary" -> lit(-1)), $"pk" >= 2) .update() ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
