HyukjinKwon commented on code in PR #47349: URL: https://github.com/apache/spark/pull/47349#discussion_r1679158703
########## sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala: ########## @@ -641,14 +641,19 @@ object SQLConf { .checkValue(_ > 0, "The value of spark.sql.leafNodeDefaultParallelism must be positive.") .createOptional + // Lazily get the number of cores to make sure SparkContext created first. + private lazy val defaultShufflePartition: Option[Int] = SparkContext.getActive.flatMap { sc => + if (sc.isLocal) Some(SparkContext.numDriverCores(sc.master)) else None Review Comment: This is only for `local[...]` so I think more common cases are just trying small data out in their local file system -well maybe this isn't the case also. I will need to run some benchmark though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org