cloud-fan commented on code in PR #47301:
URL: https://github.com/apache/spark/pull/47301#discussion_r1679031615
##########
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriterV2.scala:
##########
@@ -104,9 +106,27 @@ final class DataFrameWriterV2[T] private[sql](table:
String, ds: Dataset[T])
}
this.partitioning = Some(asTransforms)
+ validatePartitioning()
+ this
+ }
+
+ @scala.annotation.varargs
+ override def clusterBy(colName: String, colNames: String*):
CreateTableWriter[T] = {
+ this.clustering =
+ Some(ClusterByTransform((colName +: colNames).map(col =>
FieldReference(col))))
+ validatePartitioning()
this
}
+ /**
+ * Validate that clusterBy is not used with partitionBy.
+ */
+ private def validatePartitioning(): Unit = {
+ if (partitioning.nonEmpty && clustering.nonEmpty) {
Review Comment:
`DataFrameWriterV2` does not have `bucketBy`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
