cloud-fan commented on code in PR #46594:
URL: https://github.com/apache/spark/pull/46594#discussion_r1628489680
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##########
@@ -298,6 +299,11 @@ object ResolveDefaultColumns extends QueryErrorsBase
val analyzed: Expression = plan.collectFirst {
case Project(Seq(a: Alias), OneRowRelation()) => a.child
}.get
+
+ // ConstantFolding rule should evaluate expression if it is foldable to
literal
+ if (!analyzed.isInstanceOf[Literal]) {
Review Comment:
to be extra safe, shall we use the same condition used in assert and do `if
(e.resolved && e.foldable)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
