jiwen624 commented on code in PR #46714:
URL: https://github.com/apache/spark/pull/46714#discussion_r1611925610
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala:
##########
@@ -837,7 +837,8 @@ class SQLMetricsSuite extends SharedSparkSession with
SQLMetricsTestUtils
}
}
- test("SPARK-34399: Add job commit duration metrics for DataWritingCommand") {
+ test("SPARK-34399: Add job commit duration metrics for DataWritingCommand" +
+ " and SPARK-48397: Data write time metric for DataWritingCommand") {
Review Comment:
Piggyback on an existing test case to check the newly added metric of the
metrics map from
`org.apache.spark.sql.execution.datasources.BasicWriteJobStatsTracker#metrics`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
